New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicit dependency to ipython_genutils. #11317

Merged
merged 1 commit into from Oct 13, 2018

Conversation

Projects
None yet
2 participants
@Carreau
Member

Carreau commented Sep 15, 2018

This was installed because we rely on traitlets.

indent behavior is slightly different in the sens that white lines
may not have the same number of whitespace.

Remove implicit dependency to ipython_genutils.
This was installed because we rely on traitlets.

`indent` behavior is _slightly_ different in the sens that white lines
may not have the same number of whitespace.

@Carreau Carreau added this to the 7.1 milestone Sep 16, 2018

@Carreau Carreau merged commit 1dc2c97 into ipython:master Oct 13, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 6c2d9b1...0ec527d
Details
codecov/project 68.19% remains the same compared to 6c2d9b1
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Carreau Carreau deleted the Carreau:no-genutils branch Oct 13, 2018

@Carreau Carreau added Hacktoberfest and removed Hacktoberfest labels Oct 13, 2018

import textwrap
indent = lambda text,n: textwrap.indent(text,n*' ')
def dedent(text):

This comment has been minimized.

@anntzer

anntzer Oct 28, 2018

Contributor

Is this not just inspect.cleandoc?

This comment has been minimized.

@Carreau

Carreau Oct 28, 2018

Member

looks like it, do you want to make a PR?

This comment has been minimized.

@anntzer

anntzer Oct 28, 2018

Contributor

done in #11461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment