Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add the rprint and rprinte alias. #11331

Merged
merged 1 commit into from Sep 27, 2018
Merged

Conversation

@Carreau
Copy link
Member

@Carreau Carreau commented Sep 25, 2018

They are used in IPykernel 4.9 and I can see users upgrading IPython w/o
upgrading Ipykernel.

@Carreau Carreau force-pushed the Carreau:un-deprecate branch from 6787c01 to 3cb6fb9 Sep 25, 2018
They are used in IPykernel 4.9 and I can see users upgrading IPython w/o
upgrading Ipykernel.
@Carreau Carreau force-pushed the Carreau:un-deprecate branch from 3cb6fb9 to e870179 Sep 25, 2018
@Carreau Carreau requested a review from ivanov Sep 25, 2018
@minrk
Copy link
Member

@minrk minrk commented Sep 26, 2018

Agreed. I don't think there's a reason to ever remove these. The only reason to remove deprecated APIs is if their presence is actively causing a problem.

@Carreau Carreau added this to the 7.1 milestone Sep 27, 2018
@Carreau Carreau merged commit 8a9666b into ipython:master Sep 27, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +31.8% compared to 032cc8c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau Carreau deleted the Carreau:un-deprecate branch Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants