Add support for width and height arguments when displaying Video #11353
+22
−6
Conversation
Looks good ! As an improvement, you could try to see how to let users pass strings like |
9fd6be2
into
ipython:master
4 checks passed
4 checks passed
codecov/project
Absolute coverage decreased by -<.01% but relative coverage increased by +11.8% compared to 94b894d
Details
This was referenced Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR adds
width
andheight
attributes toIPython.display.Video
. The current behaviour is preserved if neither width nor height are specified. Otherwise, the specified integer will be used to set the width/height of the video in pixels, much likeIPython.display.Image
. This addresses the feature request asked for in #11328.Example usage:
Here's a notebook that exercises these attributes:
