New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an IndexError in the leading_indent input transformer #11356

Merged
merged 3 commits into from Oct 3, 2018

Conversation

Projects
None yet
2 participants
@tonyfast
Contributor

tonyfast commented Oct 2, 2018

The new input_transform interface is so much easier to use. Great work y'all.

I was experimenting with it and there was one small hiccup, leading_indent raises an IndexError when it receives an empty list. This notebook demonstrates a succesful demo and the IndexError situation.

@Carreau Carreau requested a review from takluyver Oct 2, 2018

@Carreau

This comment has been minimized.

Member

Carreau commented Oct 2, 2018

Any chance you can add a test ?

And you (of course) registered for hacktoberfest ?

@Carreau

This comment has been minimized.

Member

Carreau commented Oct 2, 2018

@meeseeksdev tag Hacktoberfest

@meeseeksdev meeseeksdev bot added the Hacktoberfest label Oct 2, 2018

@Carreau Carreau added this to the 7.1 milestone Oct 3, 2018

@Carreau

This comment has been minimized.

Member

Carreau commented Oct 3, 2018

Thanks !
Getting that in.

@Carreau Carreau merged commit b3edf6c into ipython:master Oct 3, 2018

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 68.2% (+<.01%) compared to 94b894d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment