Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix an IndexError in the leading_indent input transformer #11356
Conversation
Carreau
requested a review
from
takluyver
Oct 2, 2018
This comment has been minimized.
This comment has been minimized.
|
Any chance you can add a test ? And you (of course) registered for hacktoberfest ? |
This comment has been minimized.
This comment has been minimized.
|
@meeseeksdev tag Hacktoberfest |
meeseeksdev
bot
added
the
Hacktoberfest
label
Oct 2, 2018
tonyfast
added some commits
Oct 2, 2018
Carreau
added this to the 7.1 milestone
Oct 3, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks ! |
Carreau
merged commit b3edf6c
into
ipython:master
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tonyfast commentedOct 2, 2018
The new input_transform interface is so much easier to use. Great work y'all.
I was experimenting with it and there was one small hiccup,
leading_indentraises anIndexErrorwhen it receives an emptylist. This notebook demonstrates a succesful demo and theIndexErrorsituation.