Skip to content

/ ipython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an IndexError in the leading_indent input transformer #11356

Merged
merged 3 commits into from Oct 3, 2018
Merged

Fix an IndexError in the leading_indent input transformer #11356

merged 3 commits into from Oct 3, 2018

Conversation

@tonyfast
Copy link
Contributor

@tonyfast tonyfast commented Oct 2, 2018

The new input_transform interface is so much easier to use. Great work y'all.

I was experimenting with it and there was one small hiccup, leading_indent raises an IndexError when it receives an empty list. This notebook demonstrates a succesful demo and the IndexError situation.
@tonyfast
Fix an IndexError in leading_indent
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d4f4185
@Carreau Carreau requested a review from takluyver Oct 2, 2018
@Carreau
Copy link
Member

@Carreau Carreau commented Oct 2, 2018

Any chance you can add a test ?

And you (of course) registered for hacktoberfest ?
@Carreau
Copy link
Member

@Carreau Carreau commented Oct 2, 2018

@meeseeksdev tag Hacktoberfest
@meeseeksdev meeseeksdev bot added the Hacktoberfest label Oct 2, 2018
tonyfast added 2 commits Oct 2, 2018
@tonyfast
Add tests for null cleanup test.
8b13c4b
@tonyfast
Include empty lines condition in PromptStipper and cell_magic.
Loading status checks…
5b3ce91
@Carreau Carreau added this to the 7.1 milestone Oct 3, 2018
@Carreau
Copy link
Member

@Carreau Carreau commented Oct 3, 2018

Thanks !
Getting that in.
@Carreau Carreau merged commit b3edf6c into ipython:master Oct 3, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 68.2% (+<.01%) compared to 94b894d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takluyver takluyver

Assignees
No one assigned
Labels
Hacktoberfest
Projects
None yet
Milestone
7.1
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@tonyfast @Carreau