Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Deprecated time.clock with time.perf_counter #11376

Merged
merged 3 commits into from Oct 13, 2018
Merged

Replace Deprecated time.clock with time.perf_counter #11376

merged 3 commits into from Oct 13, 2018

Conversation

ammarmallik
Copy link
Contributor

Ref: Issue#11375
This pull request contains following:

  • Replaced deprecated time.clock with time.perf_counter
  • Updated comments around it

@ammarmallik ammarmallik mentioned this pull request Oct 8, 2018
Closed
@ammarmallik ammarmallik changed the title Hotfix/issue/11375 [Hotfix: Issue#11375] Replace Deprecated time.clock with time.perf_counter Oct 8, 2018
@ammarmallik ammarmallik changed the title [Hotfix: Issue#11375] Replace Deprecated time.clock with time.perf_counter [Hotfix] Replace Deprecated time.clock with time.perf_counter Oct 8, 2018
@minrk minrk changed the title [Hotfix] Replace Deprecated time.clock with time.perf_counter Replace Deprecated time.clock with time.perf_counter Oct 11, 2018
@minrk
Copy link
Member

minrk commented Oct 11, 2018

Thanks! There is also some use in IPython/core/magics/execution.py in the timeit magic. I think the calls there to time.time() should also be replaced with time.perf_counter().

@ammarmallik
Copy link
Contributor Author

Thanks! There is also some use in IPython/core/magics/execution.py in the timeit magic. I think the calls there to time.time() should also be replaced with time.perf_counter().

Done.

@Carreau Carreau added this to the 7.1 milestone Oct 13, 2018
@Carreau Carreau merged commit d908e3f into ipython:master Oct 13, 2018
@Carreau Carreau added Hacktoberfest you want to participate to hacktoberfest ? Here is an easy issue. and removed Hacktoberfest you want to participate to hacktoberfest ? Here is an easy issue. labels Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carreau Carreau Carreau approved these changes

Assignees
No one assigned
Labels
Hacktoberfest you want to participate to hacktoberfest ? Here is an easy issue.
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ammarmallik @minrk @Carreau