New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Deprecated time.clock with time.perf_counter #11376

Merged
merged 3 commits into from Oct 13, 2018

Conversation

Projects
None yet
3 participants
@ammarmallik
Contributor

ammarmallik commented Oct 8, 2018

Ref: Issue#11375
This pull request contains following:

  • Replaced deprecated time.clock with time.perf_counter
  • Updated comments around it

ammarmallik added some commits Oct 8, 2018

Update comments
issue#11375

@ammarmallik ammarmallik changed the title from Hotfix/issue/11375 to [Hotfix: Issue#11375] Replace Deprecated time.clock with time.perf_counter Oct 8, 2018

@ammarmallik ammarmallik changed the title from [Hotfix: Issue#11375] Replace Deprecated time.clock with time.perf_counter to [Hotfix] Replace Deprecated time.clock with time.perf_counter Oct 8, 2018

@minrk minrk changed the title from [Hotfix] Replace Deprecated time.clock with time.perf_counter to Replace Deprecated time.clock with time.perf_counter Oct 11, 2018

@minrk

This comment has been minimized.

Member

minrk commented Oct 11, 2018

Thanks! There is also some use in IPython/core/magics/execution.py in the timeit magic. I think the calls there to time.time() should also be replaced with time.perf_counter().

@ammarmallik

This comment has been minimized.

Contributor

ammarmallik commented Oct 11, 2018

Thanks! There is also some use in IPython/core/magics/execution.py in the timeit magic. I think the calls there to time.time() should also be replaced with time.perf_counter().

Done.

@Carreau Carreau added this to the 7.1 milestone Oct 13, 2018

@Carreau Carreau merged commit d908e3f into ipython:master Oct 13, 2018

4 checks passed

codecov/patch 0% of diff hit (target 0%)
Details
codecov/project 68.22% (+<.01%) compared to 65d5900
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Carreau Carreau added Hacktoberfest and removed Hacktoberfest labels Oct 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment