Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give some love to the VI mode. #11390

Merged
merged 2 commits into from Oct 14, 2018
Merged

Give some love to the VI mode. #11390

merged 2 commits into from Oct 14, 2018

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Oct 13, 2018

Improve #11329, still likely need a magic to make editign mode easier to toggle

Improve ipython#11329, still likely need a magic to make editign mode easier to toggle
@Carreau
Copy link
Member Author

Carreau commented Oct 13, 2018

@meeseeksdev[bot] tag hacktoberfest

@lumberbot-app lumberbot-app bot added the Hacktoberfest you want to participate to hacktoberfest ? Here is an easy issue. label Oct 13, 2018
@Carreau Carreau added this to the 7.1 milestone Oct 13, 2018
@Carreau Carreau merged commit a704d02 into ipython:master Oct 14, 2018
if not hasattr(self.shell.pt_app, 'editing_mode'):
return ''
if self.shell.pt_app.editing_mode == 'VI':
return '['+str(self.shell.pt_app.app.vi_state.input_mode)[3:6]+'] '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be made optional? I nearly always know what mode I'm in (and in case I forgot I'm more likely to just reach for Escape just to be sure rather than check what's at the beginning of the line), so this feature is mostly just eating away 6 characters of my terminal width...
Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Do you want to send a PR ? I guess we can either let the user define a value for both or a format string.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in #11492.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest you want to participate to hacktoberfest ? Here is an easy issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants