Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upGive some love to the VI mode. #11390
Conversation
This was referenced Oct 13, 2018
Carreau
requested a review
from
ivanov
Oct 13, 2018
This comment has been minimized.
This comment has been minimized.
|
@meeseeksdev[bot] tag hacktoberfest |
meeseeksdev
bot
added
the
Hacktoberfest
label
Oct 13, 2018
Carreau
force-pushed the
Carreau:vim-lov
branch
from
41a4cd6
to
fde1eec
Oct 13, 2018
Carreau
added this to the 7.1 milestone
Oct 13, 2018
Carreau
merged commit a704d02
into
ipython:master
Oct 14, 2018
| if not hasattr(self.shell.pt_app, 'editing_mode'): | ||
| return '' | ||
| if self.shell.pt_app.editing_mode == 'VI': | ||
| return '['+str(self.shell.pt_app.app.vi_state.input_mode)[3:6]+'] ' |
This comment has been minimized.
This comment has been minimized.
anntzer
Nov 8, 2018
Contributor
Can this be made optional? I nearly always know what mode I'm in (and in case I forgot I'm more likely to just reach for Escape just to be sure rather than check what's at the beginning of the line), so this feature is mostly just eating away 6 characters of my terminal width...
Thanks!
This comment has been minimized.
This comment has been minimized.
Carreau
Nov 11, 2018
Member
Sure. Do you want to send a PR ? I guess we can either let the user define a value for both or a format string.
This comment has been minimized.
This comment has been minimized.
Carreau
deleted the
Carreau:vim-lov
branch
Nov 11, 2018
anntzer
referenced this pull request
Nov 11, 2018
Merged
Make inclusion of vi mode in prompt togglable. #11492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Carreau commentedOct 13, 2018
Improve #11329, still likely need a magic to make editign mode easier to toggle