Give some love to the VI mode. #11390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve ipython#11329, still likely need a magic to make editign mode easier to toggle
This was referenced Oct 13, 2018
|
@meeseeksdev[bot] tag hacktoberfest |
lumberbot-app
bot
added
the
Hacktoberfest
anntzer
reviewed
Nov 8, 2018
| if not hasattr(self.shell.pt_app, 'editing_mode'): | ||
| return '' | ||
| if self.shell.pt_app.editing_mode == 'VI': | ||
| return '['+str(self.shell.pt_app.app.vi_state.input_mode)[3:6]+'] ' |
There was a problem hiding this comment.
Can this be made optional? I nearly always know what mode I'm in (and in case I forgot I'm more likely to just reach for Escape just to be sure rather than check what's at the beginning of the line), so this feature is mostly just eating away 6 characters of my terminal width...
Thanks!
There was a problem hiding this comment.
Sure. Do you want to send a PR ? I guess we can either let the user define a value for both or a format string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve #11329, still likely need a magic to make editign mode easier to toggle