New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give some love to the VI mode. #11390

Merged
merged 2 commits into from Oct 14, 2018

Conversation

Projects
None yet
2 participants
@Carreau
Member

Carreau commented Oct 13, 2018

Improve #11329, still likely need a magic to make editign mode easier to toggle

Give some love to the VI mode.
Improve #11329, still likely need a magic to make editign mode easier to toggle
@Carreau

This comment has been minimized.

Member

Carreau commented Oct 13, 2018

@meeseeksdev[bot] tag hacktoberfest

@meeseeksdev meeseeksdev bot added the Hacktoberfest label Oct 13, 2018

@Carreau Carreau force-pushed the Carreau:vim-lov branch from 41a4cd6 to fde1eec Oct 13, 2018

@Carreau Carreau added this to the 7.1 milestone Oct 13, 2018

@Carreau Carreau merged commit a704d02 into ipython:master Oct 14, 2018

4 checks passed

codecov/patch 17.64% of diff hit (target 0%)
Details
codecov/project 68.26% (+0.01%) compared to 32eec53
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
if not hasattr(self.shell.pt_app, 'editing_mode'):
return ''
if self.shell.pt_app.editing_mode == 'VI':
return '['+str(self.shell.pt_app.app.vi_state.input_mode)[3:6]+'] '

This comment has been minimized.

@anntzer

anntzer Nov 8, 2018

Contributor

Can this be made optional? I nearly always know what mode I'm in (and in case I forgot I'm more likely to just reach for Escape just to be sure rather than check what's at the beginning of the line), so this feature is mostly just eating away 6 characters of my terminal width...
Thanks!

This comment has been minimized.

@Carreau

Carreau Nov 11, 2018

Member

Sure. Do you want to send a PR ? I guess we can either let the user define a value for both or a format string.

This comment has been minimized.

@anntzer

anntzer Nov 11, 2018

Contributor

done in #11492.

@Carreau Carreau deleted the Carreau:vim-lov branch Nov 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment