Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix miss-capturing of assign statement after a dedent. #11418
Conversation
Carreau
requested a review
from
takluyver
Oct 20, 2018
Carreau
added this to the 7.1 milestone
Oct 20, 2018
Carreau
merged commit 5c506dc
into
ipython:master
Oct 21, 2018
Carreau
deleted the
Carreau:fix-assign-detection
branch
Oct 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Carreau commentedOct 20, 2018
•
edited
closes #11415
This fixes a bug where assign statement were miscaptured when occuring
after a dedent. This was due to the fact that :
That is to say the empty string is in any strings.
Add a couple of integration tests and unit tests as well, and also add a
warning to public function when not used properly, in particular, check
that lines passed to make_tokens_by_line do end with an endline marker
(at least for the first line), otherwise the function does not behave
properly.