New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSX on 3.6 and 3.7 to travis, use addons.apt:packages for graphviz #11471

Merged
merged 18 commits into from Nov 1, 2018

Conversation

Projects
None yet
3 participants
@bollwyvl
Contributor

bollwyvl commented Oct 31, 2018

This adds 3.6/3.7 OSX builds to the travis-ci matrix. No doubt this comes at greater cost to shared resources per PR, but so it goes!

In reading the Travis docs, this also moves the apt install up to the addon level, since we weren't pinning or anything. The equivalent brew command is also moved up to before_install. (not building docs on osx)

c/f conda-forge/ipython-feedstock#63 (comment)

@bollwyvl

This comment has been minimized.

Contributor

bollwyvl commented Oct 31, 2018

New matrix looks like I didn't screw anything major up... yet:
screenshot from 2018-10-30 21-18-30

@bollwyvl

This comment has been minimized.

Contributor

bollwyvl commented Oct 31, 2018

Har:

3.6 is not installed; attempting download
Downloading archive: https://s3.amazonaws.com/travis-python-archives/binaries/osx/10.13/x86_64/python-3.6.tar.bz2
$ curl -sSf -o python-3.6.tar.bz2 ${archive_url}
curl: (22) The requested URL returned error: 403 Forbidden
Unable to download 3.6 archive. The archive may not exist. Please consider a different version.
@bollwyvl

This comment has been minimized.

Contributor

bollwyvl commented Oct 31, 2018

Right, about those docs... will brew up some python...

bollwyvl added some commits Oct 31, 2018

@bollwyvl

This comment has been minimized.

Contributor

bollwyvl commented Oct 31, 2018

Great, looks like the OSX CI is going through. The allowed nightly fail appears to not be related to this.

The first working 3.6 build took 8 minutes, and was slower to start anyway. Investigating whether caching the built pythons makes a net difference (of course, would need to succeed....)

@bollwyvl

This comment has been minimized.

Contributor

bollwyvl commented Oct 31, 2018

Oh, I love you, first ✔️. Ooh, and coverage went up!

bollwyvl added some commits Oct 31, 2018

@bollwyvl

This comment has been minimized.

Contributor

bollwyvl commented Oct 31, 2018

Ugh, looks like the cache situation isn't great: appears to have cached bin/ipython and friends, and we have no interest in that. So, we're looking at 8-9 minutes for the OSX builds at present. Thoughts?

@minrk

This comment has been minimized.

Member

minrk commented Oct 31, 2018

Updating homebrew and building Python from source with pyenv both take a pretty long time. I added a commit with a couple small changes:

  • only install Python if not present
  • install Python binaries from Python.org instead of from source
  • avoid updating homebrew

The mac builds now complete in 3 minutes.

use binaries for Python on mac
instead of building from source with pipenv

saves several minutes

@minrk minrk force-pushed the bollwyvl:ci/osx branch from 3d5a637 to ef38933 Oct 31, 2018

@bollwyvl

This comment has been minimized.

Contributor

bollwyvl commented Oct 31, 2018

@Carreau

This comment has been minimized.

Member

Carreau commented Oct 31, 2018

Do we still have a JS group ?

+1 will look at it closer from my phone.

@Carreau

This comment has been minimized.

Member

Carreau commented Oct 31, 2018

*from my desktop

bollwyvl added some commits Nov 1, 2018

@bollwyvl

This comment has been minimized.

Contributor

bollwyvl commented Nov 1, 2018

Do we still have a JS group ?

No, removed!

@bollwyvl

This comment has been minimized.

Contributor

bollwyvl commented Nov 1, 2018

Here's the only virtualenv coverage change:

https://codecov.io/gh/ipython/ipython/compare/70d51e3...a39b70da8c26968e72342f231f9349cc52fd69b5/changes

Probably not worth worrying about.

@Carreau Carreau merged commit 8840769 into ipython:master Nov 1, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 6eee2de...678e344
Details
codecov/project 68.39% (+0.08%) compared to 6eee2de
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bollwyvl

This comment has been minimized.

Contributor

bollwyvl commented Nov 1, 2018

@Carreau Carreau added this to the 7.2 milestone Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment