New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inclusion of vi mode in prompt togglable. #11492

Merged
merged 1 commit into from Nov 11, 2018

Conversation

Projects
None yet
2 participants
@anntzer
Contributor

anntzer commented Nov 11, 2018

See discussion in #11390 (comment).

If we really want to make the prompt configurable I guess the config value could be a function taking an InputMode as argument and returning a string, but that feels a bit overkill?

@Carreau

This comment has been minimized.

Member

Carreau commented Nov 11, 2018

LGTM.

@Carreau Carreau merged commit a28a444 into ipython:master Nov 11, 2018

4 checks passed

codecov/patch 50% of diff hit (target 0%)
Details
codecov/project 68.39% (+<.01%) compared to 27d0242
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Carreau Carreau added this to the 7.2 milestone Nov 11, 2018

@anntzer anntzer deleted the anntzer:prompt-includes-vi-mode branch Nov 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment