Fix extension detection#11499
Merged
Carreau merged 2 commits intoipython:masterfrom Nov 19, 2018
chbrown:patch-1
Merged
Conversation
If the path leading up to the Python installation's `site-packages` contains a `.`, this check does not do what it says it does :(
For instance, on macOS, the `site-packages` directory is located at `/usr/local/lib/python3.7/site-packages`, which means that trying to use the magic `%run -m my.module` will always fail, because `split_path[1]` will always start with `7/site-packages`.
There are better ways to check that a file extension matches expectations, but I thought it was cute that I could fix this bug by inserting a single character :)
My current workaround looks like this:
```python
import importlib
import_path = importlib.util.find_spec('my.module').origin
%run $import_path
```
Member
|
THanks that seem reasonable, I'll see if I can add a test to make sure there is no regressions. |
Member
|
I've modified test to check for multiple dot in path. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the path leading up to the Python installation's
site-packagescontains a., this check does not do what it says it does :(For instance, on macOS, the
site-packagesdirectory is located at/usr/local/lib/python3.7/site-packages, which means that trying to use the magic%run -m my.modulewill always fail, becausesplit_path[1]will always start with7/site-packages.There are better ways to check that a file extension matches expectations, but I thought it was cute that I could fix this bug by inserting a single character :)
My current workaround looks like this: