New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CWD to sys.path *after* stdlib #11502

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
2 participants
@minrk
Member

minrk commented Nov 21, 2018

this deviates from Python's own interactive behavior, but seems to avoid problems where folks create stdlib-names like email.py.

They can still collide with packages, but that seems less common than generic names like email and code.

I'm not entirely sure if it's a good idea to deviate from Python like this, but it would solve a problem that confuses our users from time to time.

add CWD to sys.path *after* stdlib
this deviates from Python's own interactive behavior,
but seems to avoid problems where folks create stdlib-names like `email.py`.

They can still collide with packages,
but that seems less common than generic names like `email` and `code`
@Carreau

This comment has been minimized.

Member

Carreau commented Nov 27, 2018

+1. Do you want to add a test ?

@Carreau Carreau added this to the 7.2 milestone Nov 29, 2018

@Carreau

This comment has been minimized.

Member

Carreau commented Nov 29, 2018

Probably rare enough to not need test.

@Carreau Carreau merged commit 1b0c1b9 into ipython:master Nov 29, 2018

4 checks passed

codecov/patch 0% of diff hit (target 0%)
Details
codecov/project 68.38% (-0.02%) compared to 5e7f930
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment