Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render signatures ourselves if they’re too long #11505

Merged
merged 5 commits into from Nov 26, 2018
Merged

Render signatures ourselves if they’re too long #11505

merged 5 commits into from Nov 26, 2018

Conversation

flying-sheep
Copy link
Contributor

Fixes #11504

@flying-sheep flying-sheep mentioned this pull request Nov 21, 2018
Closed
minrk
minrk reviewed Nov 21, 2018
View reviewed changes
IPython/core/oinspect.py Outdated Show resolved Hide resolved
IPython/core/oinspect.py Outdated Show resolved Hide resolved
@flying-sheep
Copy link
Contributor Author

@minrk I think this should be good to go, what do you think?

@minrk minrk merged commit 90e50b4 into ipython:master Nov 26, 2018
@minrk
Copy link
Member

minrk commented Nov 26, 2018

Looks great, thanks @flying-sheep!

@flying-sheep flying-sheep deleted the patch-2 branch November 26, 2018 16:07
@flying-sheep
Copy link
Contributor Author

awesome!

@Carreau Carreau added this to the 7.2 milestone Nov 29, 2018
This was referenced Dec 6, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minrk minrk minrk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flying-sheep @minrk @Carreau