Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render signatures ourselves if they’re too long #11505

Merged
merged 5 commits into from Nov 26, 2018
Merged

Conversation

@flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Nov 21, 2018

Fixes #11504

Fixes #11504
IPython/core/oinspect.py Outdated Show resolved Hide resolved
IPython/core/oinspect.py Outdated Show resolved Hide resolved
@flying-sheep
Copy link
Contributor Author

@flying-sheep flying-sheep commented Nov 26, 2018

@minrk I think this should be good to go, what do you think?

@minrk minrk merged commit 90e50b4 into ipython:master Nov 26, 2018
4 checks passed
4 checks passed
codecov/patch 88.46% of diff hit (target 0%)
Details
codecov/project 68.42% (+0.01%) compared to 5e7f930
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minrk
Copy link
Member

@minrk minrk commented Nov 26, 2018

Looks great, thanks @flying-sheep!

@flying-sheep flying-sheep deleted the flying-sheep:patch-2 branch Nov 26, 2018
@flying-sheep
Copy link
Contributor Author

@flying-sheep flying-sheep commented Nov 26, 2018

awesome!

@Carreau Carreau added this to the 7.2 milestone Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants