Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable jedi if it’s installed #11506

Merged
merged 1 commit into from Nov 29, 2018

Conversation

@flying-sheep
Copy link
Contributor

commented Nov 21, 2018

Fixes #11503

@Carreau

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

Looks good. Many thanks !

@Carreau Carreau added this to the 7.2 milestone Nov 29, 2018

@Carreau Carreau merged commit faa0fd9 into ipython:master Nov 29, 2018

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +31.59% compared to 5e7f930
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@flying-sheep flying-sheep deleted the flying-sheep:patch-3 branch Nov 29, 2018

@flying-sheep

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2018

great!

@dandavison

This comment has been minimized.

Copy link

commented Jun 3, 2019

Jedi completion doesn't seem to be working on python objects in various common scenarios, see #11609. Would it make sense to remove jedi from install_requires so that it's not on by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.