Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply @needs_local_scope to cell magics. #11542

Merged
merged 2 commits into from Mar 12, 2019

Conversation

@Carreau
Copy link
Member

commented Jan 4, 2019

While technically this will not be completely needed (at cell magics
cannot be in nested scope), it make the API a tiny bit more consistent
between line and cell magics.

(Bug report I recieved personally that will be submitted later)

Apply @needs_local_scope to cell magics.
While technically this will not be completely needed (at cell magics
cannot be in nested scope), it make the API a tiny bit more consistent
between line and cell magics.

(Bug report I recieved personally that will be submitted later)

@Carreau Carreau force-pushed the Carreau:local-scope branch 2 times, most recently from 25e9f03 to 43246e6 Jan 4, 2019

@takluyver

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

Did you get round to filing the bug report about this?

@Carreau

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2019

No, I need to translate it from french. I'm slowly coming back the cluster was under maintnance for the last few days so it was taking all my time.

@Carreau Carreau added this to the 7.4 milestone Mar 12, 2019

@Carreau Carreau merged commit f0f6cd8 into ipython:master Mar 12, 2019

4 checks passed

codecov/patch 25% of diff hit (target 0%)
Details
codecov/project 68.76% (+0.42%) compared to c937798
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Carreau Carreau deleted the Carreau:local-scope branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.