Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply @needs_local_scope to cell magics. #11542

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Jan 4, 2019

While technically this will not be completely needed (at cell magics
cannot be in nested scope), it make the API a tiny bit more consistent
between line and cell magics.

(Bug report I recieved personally that will be submitted later)

While technically this will not be completely needed (at cell magics
cannot be in nested scope), it make the API a tiny bit more consistent
between line and cell magics.

(Bug report I recieved personally that will be submitted later)
@Carreau Carreau force-pushed the local-scope branch 2 times, most recently from 25e9f03 to 43246e6 Compare January 4, 2019 18:53
@takluyver
Copy link
Member

Did you get round to filing the bug report about this?

@Carreau
Copy link
Member Author

Carreau commented Jan 18, 2019

No, I need to translate it from french. I'm slowly coming back the cluster was under maintnance for the last few days so it was taking all my time.

@Carreau Carreau added this to the 7.4 milestone Mar 12, 2019
@Carreau Carreau merged commit f0f6cd8 into ipython:master Mar 12, 2019
@Carreau Carreau deleted the local-scope branch June 13, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants