Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PyQt 5.11 backwards incompatibility causing sip import failure #11613

Merged
merged 2 commits into from Feb 21, 2019

Conversation

@flutefreak7
Copy link

commented Feb 20, 2019

See issue: #11612

This is the same fix as implemented in jupyter/qtconsole#319.

@tacaswell

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2019

Could the sip import simply be deleted? It is not returned from the function and you can not change the API version on pyqt5.

@flutefreak7

This comment has been minimized.

Copy link
Author

commented Feb 20, 2019

That's a good point... it should probably just be removed since it doesn't get used and is likely a leftover.

Removing it works on my end, so I'll do that for the PR.

@Carreau Carreau added this to the 7.4 milestone Feb 21, 2019

@Carreau

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

Sounds good. Thanks !

@Carreau Carreau merged commit 19b47fa into ipython:master Feb 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.