Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load unicode names #11693

Merged
merged 1 commit into from May 10, 2019
Merged

Conversation

@zzzz-qq
Copy link
Contributor

@zzzz-qq zzzz-qq commented Apr 18, 2019

Lazy load unicode names when they are used first time rather than when ipython startup.

@Carreau
Copy link
Member

@Carreau Carreau commented Apr 19, 2019

@LucianaMarques that's your code, you might want to review it;

But otherwise that's looks good to me.

@LucianaMarques
Copy link
Contributor

@LucianaMarques LucianaMarques commented Apr 25, 2019

Hey there, sorry for the late reply.

If tests are working and this will improve performance, I don't see why not accept it :) That's actually really nice improvement, thanks!

I would like though that you provide us more info on the profiling you did, how you did it, etc. I'm not used to profiling yet and I would certainly like to learn more about it.

I am doing some work in the completer class, if you have some more suggestions I would love to hear it.

Copy link
Contributor

@LucianaMarques LucianaMarques left a comment

I just did a review on your pull request. Please take some time to consider my comments and let's discuss them :)

Also, I like to put descriptions in my pull requests, even if it's just something like "closes issue number #x". It's important to keep things documented in my opinion.

IPython/core/completer.py Show resolved Hide resolved
IPython/core/completer.py Show resolved Hide resolved
IPython/core/completer.py Show resolved Hide resolved
IPython/core/completer.py Show resolved Hide resolved
@Carreau
Copy link
Member

@Carreau Carreau commented Apr 25, 2019

Hey there, sorry for the late reply.

No need to apologize, we are all busy.
Those were really good comment and questions.

I would like though that you provide us more info on the profiling you did, how you did it, etc. I'm not used to profiling yet and I would certainly like to learn more about it.

I don't think much profiling is necessary. It won't be "faster" in all cases, it will mostly delay the computation of the unicodes mapping until actually requested.

This mean that the startup of IPython will be a bit faster, but the first press on <tab> that needs completion will be a bit slower.

@LucianaMarques
Copy link
Contributor

@LucianaMarques LucianaMarques commented Apr 25, 2019

I have one more code comment but i'm on my phone now, please wait before merging just a little bit.

@Carreau
Copy link
Member

@Carreau Carreau commented Apr 25, 2019

I have one more code comment but i'm on my phone now, please wait before merging just a little bit.

Don't worry plenty of time we'll wait for your approval.

IPython/core/completer.py Outdated Show resolved Hide resolved
@LucianaMarques
Copy link
Contributor

@LucianaMarques LucianaMarques commented Apr 26, 2019

Don't worry plenty of time we'll wait for your approval.

Thanks! Just to sum up, only exclude the comment I mentioned above and add some description to the PR, and in my opinion it's ready to be merged.

@zzzz-qq zzzz-qq force-pushed the lazy-load-unicode-names-dev branch from 93ed931 to c69876f Apr 26, 2019
@zzzz-qq
Copy link
Contributor Author

@zzzz-qq zzzz-qq commented Apr 26, 2019

Hey there, sorry for the late reply.

No need to apologize, we are all busy.
Those were really good comment and questions.

I would like though that you provide us more info on the profiling you did, how you did it, etc. I'm not used to profiling yet and I would certainly like to learn more about it.

I don't think much profiling is necessary. It won't be "faster" in all cases, it will mostly delay the computation of the unicodes mapping until actually requested.

This mean that the startup of IPython will be a bit faster, but the first press on <tab> that needs completion will be a bit slower.

@Carreau Really appreaciate your patience and kindness.

@Carreau Carreau added this to the 7.6 milestone Apr 26, 2019
@Carreau
Copy link
Member

@Carreau Carreau commented Apr 26, 2019

Really appreciate your patience and kindness.

Thanks much appreciated; I wish I had more time to mentor and guide others.
Thanks to you for taking the time to send a pull-request, and allow us to discuss it; I know it can be frustrating to wait.

I just released 7.5 yesterday so this did not make the cut, but I'm hopping to get that in 7.6 next month.

@LucianaMarques
Copy link
Contributor

@LucianaMarques LucianaMarques commented Apr 28, 2019

@Carreau are we wainting for 7.6 to merge this PR? I don't have merge permission, so I was just wandering why you didn't merge this yet.

@Carreau
Copy link
Member

@Carreau Carreau commented May 10, 2019

Thanks; I have some time to look at ongoing PRs, merging this.

Thanks both !

@Carreau Carreau merged commit 380db0d into ipython:master May 10, 2019
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants