-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Fix magic time #11716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix magic time #11716
Conversation
Looks good to me, I'll try to see if I can come up with test to make sure the behavior does not regress. |
IPython/core/magics/execution.py
Outdated
self.shell.showtraceback() | ||
return | ||
self.shell.showtraceback() | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaken this only adds extra unneeded spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean showtraceback() ? That would be for the entire try block (from line 1301 to 1305)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thank you ! Fixed that now, should be fine.
Thanks for your patience, I rebased and squashed a few commits to not have the whitespaces changes in history, plus added a test. Once test passes I'm happy to merge this. Thanks. |
Thanks @Pragnya02 ! |
In case of %%time with multi-lines in cell , eval the last line and display in output instead of suppressing it.
Refer Issue : #11707