Fix magic time #11716
Merged
Fix magic time #11716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, I'll try to see if I can come up with test to make sure the behavior does not regress. |
gpotter2
reviewed
May 10, 2019
IPython/core/magics/execution.py
Outdated
| self.shell.showtraceback() | ||
| return | ||
| self.shell.showtraceback() | ||
| return |
There was a problem hiding this comment.
If I'm not mistaken this only adds extra unneeded spaces.
There was a problem hiding this comment.
Did you mean showtraceback() ? That would be for the entire try block (from line 1301 to 1305)
There was a problem hiding this comment.
What I meant was that your diff is full of spacing changes 😄
There was a problem hiding this comment.
Oops, thank you ! Fixed that now, should be fine.
|
Thanks for your patience, I rebased and squashed a few commits to not have the whitespaces changes in history, plus added a test. Once test passes I'm happy to merge this. Thanks. |
Carreau
reviewed
May 25, 2019
|
Thanks @Pragnya02 ! |
This was referenced Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of %%time with multi-lines in cell , eval the last line and display in output instead of suppressing it.
Refer Issue : #11707