Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix magic time #11716
Conversation
This comment has been minimized.
This comment has been minimized.
|
Looks good to me, I'll try to see if I can come up with test to make sure the behavior does not regress. |
gpotter2
reviewed
May 10, 2019
IPython/core/magics/execution.py
Outdated
| self.shell.showtraceback() | ||
| return | ||
| self.shell.showtraceback() | ||
| return |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pragnya02
May 10, 2019
Author
Contributor
Did you mean showtraceback() ? That would be for the entire try block (from line 1301 to 1305)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Carreau
force-pushed the
Pragnya02:fix_magic_time
branch
from
203afd0
to
e7cc2e5
May 25, 2019
Pragnya02
and others
added some commits
May 8, 2019
Carreau
force-pushed the
Pragnya02:fix_magic_time
branch
from
e7cc2e5
to
167e67e
May 25, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks for your patience, I rebased and squashed a few commits to not have the whitespaces changes in history, plus added a test. Once test passes I'm happy to merge this. Thanks. |
Carreau
reviewed
May 25, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks @Pragnya02 ! |
Carreau
merged commit de0abd8
into
ipython:master
May 26, 2019
Carreau
added this to the 7.6 milestone
May 26, 2019
This was referenced Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Pragnya02 commentedMay 9, 2019
In case of %%time with multi-lines in cell , eval the last line and display in output instead of suppressing it.
Refer Issue : #11707