Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python-3.8 PEP570 positional only argument #11720

Merged
merged 2 commits into from May 12, 2019

Conversation

@stonebig
Copy link
Contributor

commented May 11, 2019

to solve #11719

stonebig added some commits May 11, 2019

@Carreau Carreau added this to the 7.6 milestone May 12, 2019

@Carreau

This comment has been minimized.

Copy link
Member

commented May 12, 2019

I'm going to merge this – having the test-not passing on 3.8 annoys me for some other work – though I may revert it if we don't need to call removed_co_newlocals in 3.8 final, hope that is ok.

@Carreau Carreau merged commit 8dff478 into ipython:master May 12, 2019

4 checks passed

codecov/patch 66.66% of diff hit (target 0%)
Details
codecov/project 68.96% (-0.01%) compared to 380db0d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Hi there, You seem to run IPython on Python 3.8; do you mind trying #11713 that tried to make use of the new 3.8b1 (not out yet) top-level await ?

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.