Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

core.completer: Clean up excessive and unused code. #1175

Merged
merged 1 commit into from Dec 27, 2011

Conversation

Projects
None yet
2 participants
Contributor

bfroehle commented Dec 18, 2011

  • mark_dirs is only called from one location and it is more simply
    expressed as a one-liner using the ternary operator.
  • single_dir_expand is not called from anywhere in IPython.
@bfroehle bfroehle core.completer: Clean up excessive and unused code.
- `mark_dirs` is only called from one location and it is more simply
  expressed as a one-liner using the ternary operator.
- `single_dir_expand` is not called from anywhere in IPython.
bf4a4f4
Owner

minrk commented Dec 27, 2011

This looks clean and sensible, thanks!

@minrk minrk added a commit that referenced this pull request Dec 27, 2011

@minrk minrk Merge pull request #1175 from bfroehle/completer_cleanup
* remove mark_dirs, which can be expressed as list comprehension.
* remove single_dir_expand, which is no longer used anywhere.
3cda5da

@minrk minrk merged commit 3cda5da into ipython:master Dec 27, 2011

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

@minrk minrk Merge pull request #1175 from bfroehle/completer_cleanup
* remove mark_dirs, which can be expressed as list comprehension.
* remove single_dir_expand, which is no longer used anywhere.
320eff0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment