Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Allow setting a custom timeout scale #11756

Merged
merged 1 commit into from May 31, 2019

Conversation

@hroncok
Copy link
Contributor

commented May 28, 2019

Add environment variable IPYTHON_TESTING_TIMEOUT_SCALE that can be used to scale all the timeouts in tests.

Useful on slow machines, such as Fedora armv7hl/aarch64 builders.

Fixes #11754

@Carreau

This comment has been minimized.

Copy link
Member

commented May 30, 2019

I'm wondering if we should have a global IPYTHON_TESTING_TIMEOUT_SCALE that is used to scale all the current (and future) timeout everywhere. There is only 3 so far... but you never know.

Thoughts ?

IPython/terminal/tests/test_debug_magic.py
34:    child.timeout = 15
38:    child.timeout = 2

IPython/terminal/tests/test_embed.py
75:    child.timeout = 5
Tests: Allow setting a custom timeout scale
Add environment variable IPYTHON_TESTING_TIMEOUT_SCALE that can
be used to scale all the timeouts in tests.

Useful on slow machines, such as Fedora armv7hl/aarch64 builders.

Fixes #11754

@hroncok hroncok force-pushed the hroncok:timeout branch from e9e6638 to e8d8a60 May 30, 2019

@hroncok hroncok changed the title Allow setting a custom timeout in test_nest_embed Tests: Allow setting a custom timeout scale May 30, 2019

@Carreau

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Thanks !

@Carreau Carreau merged commit ed890ca into ipython:master May 31, 2019

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 69.01% (+<.01%) compared to 78886a9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Carreau Carreau added this to the 7.6 milestone May 31, 2019

@hroncok hroncok deleted the hroncok:timeout branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.