Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Allow setting a custom timeout scale #11756

Merged
merged 1 commit into from
May 31, 2019
Merged

Tests: Allow setting a custom timeout scale #11756

merged 1 commit into from
May 31, 2019

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented May 28, 2019 •
edited
Loading

Add environment variable IPYTHON_TESTING_TIMEOUT_SCALE that can be used to scale all the timeouts in tests.

Useful on slow machines, such as Fedora armv7hl/aarch64 builders.

Fixes #11754

@Carreau
Copy link
Member

Carreau commented May 30, 2019

I'm wondering if we should have a global IPYTHON_TESTING_TIMEOUT_SCALE that is used to scale all the current (and future) timeout everywhere. There is only 3 so far... but you never know.

Thoughts ?

IPython/terminal/tests/test_debug_magic.py
34:    child.timeout = 15
38:    child.timeout = 2

IPython/terminal/tests/test_embed.py
75:    child.timeout = 5

@hroncok
Tests: Allow setting a custom timeout scale
e8d8a60 
Add environment variable IPYTHON_TESTING_TIMEOUT_SCALE that can
be used to scale all the timeouts in tests.

Useful on slow machines, such as Fedora armv7hl/aarch64 builders.

Fixes ipython#11754
@hroncok hroncok changed the title Allow setting a custom timeout in test_nest_embed Tests: Allow setting a custom timeout scale May 30, 2019
@Carreau
Copy link
Member

Carreau commented May 31, 2019

Thanks !

@Carreau Carreau merged commit ed890ca into ipython:master May 31, 2019
@Carreau Carreau added this to the 7.6 milestone May 31, 2019
@hroncok hroncok deleted the timeout branch July 3, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.6
Development

Successfully merging this pull request may close these issues.

Arm failures in test_embed.test_nest_embed
2 participants
@hroncok @Carreau