Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time magic, #11812

Merged
merged 3 commits into from Jul 3, 2019

Conversation

@Carreau
Copy link
Member

commented Jul 2, 2019

Time magic was eagerly assuming the last node in an ast tree was an Expr, which lead t crashes.

Fixes #11811 #11809

@kernc

This comment has been minimized.

Copy link

commented Jul 3, 2019

Tested, works. Thanks for promptness!

@Carreau Carreau added this to the 7.6 milestone Jul 3, 2019

@Carreau Carreau merged commit 147ab7f into ipython:master Jul 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Carreau Carreau deleted the Carreau:fix-time branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.