Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix %matplotlib #11814

Merged
merged 1 commit into from Jul 7, 2019

Conversation

@OriolAbril
Copy link
Contributor

commented Jul 4, 2019

Hey, I did a PR some days ago (#11748) in order to allow %matplotlib to accept uppercase backend names. However, I have just realized that I totally overlooked the fact that args.gui may not be a str. I think it can only be none or a string, but I feel this solution is safer. I am really sorry because now %matplotlib with no backend does not work.

@Carreau

Fix %matplotlib
args.gui may not be a str
@OriolAbril

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

Oh, vim removed all the spaces it deemed as unnecessary. Should I undo this change to leave the diff as one line?

@Carreau

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

Oh, vim removed all the spaces it deemed as unnecessary. Should I undo this change to leave the diff as one line?

Well, usually I don't like it, but it happens often enough that removing them if fine and will prevent it from happening again.

@Carreau Carreau added this to the 7.7 milestone Jul 7, 2019

@Carreau Carreau merged commit 8c3acd2 into ipython:master Jul 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.