Fix %matplotlib#11814
Merged
Carreau merged 1 commit intoipython:masterfrom Jul 7, 2019
OriolAbril:matplotlib-uppercase
Merged
Conversation
args.gui may not be a str
Contributor
Author
|
Oh, vim removed all the spaces it deemed as unnecessary. Should I undo this change to leave the diff as one line? |
Member
Well, usually I don't like it, but it happens often enough that removing them if fine and will prevent it from happening again. |
Member
|
Thanks ! |
This was referenced Jul 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I did a PR some days ago (#11748) in order to allow
%matplotlibto accept uppercase backend names. However, I have just realized that I totally overlooked the fact thatargs.guimay not be astr. I think it can only be none or a string, but I feel this solution is safer. I am really sorry because now%matplotlibwith no backend does not work.@Carreau