Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Python 4 #11874

Merged
merged 1 commit into from Sep 8, 2019
Merged

Fix for Python 4 #11874

merged 1 commit into from Sep 8, 2019

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Sep 3, 2019

We don't yet know if 3.10 or 4.0 will follow Python 3.9, but whichever it is, it will probably happen in 2020 when Python 3.9 reaches beta and work begins on Python 3.9+1.

On Python 4, this would exit:

if sys.version_info[0] == 3:
    print("This script must be run with Python 3, exiting...")
    sys.exit(1)

Found using https://github.com/asottile/flake8-2020:

$ pip install -U flake8-2020
...
$ flake8 --select YTT
./tools/gen_latex_symbols.py:14:8: YTT201 `sys.version_info[0] == 3` referenced (python4), use `>=`
@Carreau Carreau added this to the 7.9 milestone Sep 8, 2019
@Carreau
Copy link
Member

@Carreau Carreau commented Sep 8, 2019

Sounds great !

@Carreau Carreau merged commit f328401 into ipython:master Sep 8, 2019
2 checks passed
@hugovk hugovk deleted the fix-flake8-2020 branch Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants