Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching update_instance() to gc.get_referrers() #11876

Merged

Conversation

@daharn
Copy link
Contributor

@daharn daharn commented Sep 4, 2019

The resulting code is almost laughably simple and should also be way more efficient than the previous attempt.

@daharn
Copy link
Contributor Author

@daharn daharn commented Sep 5, 2019

Although I overlooked that you already implemented something using gc, this further reduces the amount of objects to search and might further improve performance.

@Carreau
Copy link
Member

@Carreau Carreau commented Sep 8, 2019

Thanks for working on this ! If that woks for you let's get that in.

@Carreau Carreau merged commit cd54f15 into ipython:master Sep 8, 2019
2 checks passed
@Carreau Carreau mentioned this pull request Sep 8, 2019
@esvhd
Copy link

@esvhd esvhd commented Oct 2, 2019

Thanks for fixing this folks. When do you expect 7.9 to hit the road?

@daharn daharn deleted the autoreload-fix-using-gc.get_referrers() branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants