switching update_instance() to gc.get_referrers() #11876
Merged
Carreau merged 1 commit intoSep 8, 2019
Merged
Conversation
…ly) efficient update of old class instances
Contributor
Author
|
Although I overlooked that you already implemented something using gc, this further reduces the amount of objects to search and might further improve performance. |
Member
|
Thanks for working on this ! If that woks for you let's get that in. |
Closed
|
Thanks for fixing this folks. When do you expect 7.9 to hit the road? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resulting code is almost laughably simple and should also be way more efficient than the previous attempt.