Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restoring more than 2 variables and support storing multiple variables %storemagic #11930

Merged
merged 1 commit into from Nov 12, 2019

Conversation

gokceneraslan
Copy link
Contributor

@gokceneraslan gokceneraslan commented Oct 27, 2019

Currently %store -r a b c doesn't restore c because argument splitting is not performed correctly (see args = argsl.split(None,1) below). This is now fixed. %store a b c was not supported before, now it is working well. I also extended the tests to cover all scenarios.

@gokceneraslan gokceneraslan changed the title Fix restoring more than 2 variables and add support for storing multiple variables Fix restoring more than 2 variables and support storing multiple variables %storemagic Oct 27, 2019
@Carreau Carreau added this to the 7.10 milestone Nov 12, 2019
@Carreau
Copy link
Member

@Carreau Carreau commented Nov 12, 2019

Thanks, that looks reasonable to me !

@Carreau Carreau merged commit 61c7048 into ipython:master Nov 12, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants