Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added arm64 jobs in Travis-CI #12073

Merged
merged 1 commit into from Jan 12, 2020
Merged

Added arm64 jobs in Travis-CI #12073

merged 1 commit into from Jan 12, 2020

Conversation

ossdev07
Copy link
Contributor

@ossdev07 ossdev07 commented Jan 2, 2020

Travis-CI has added support for ARM64. Added ARM64 jobs in Travis-CI.

@@ -223,7 +223,7 @@ def is_stable(extra):
htmlhelp_basename = 'ipythondoc'

intersphinx_mapping = {'python': ('https://docs.python.org/3/', None),
'rpy2': ('https://rpy2.readthedocs.io/en/version_2.8.x/', None),
'rpy2': ('https://rpy2.readthedocs.io/en/latest/', None),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should explain in the commit message why you have updated this line, as it is not obvious why it relates to adding an Arm64 Travis-ci job.

Copy link
Member

@Carreau Carreau Jan 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That has been fixed in master; I'll rebase so that it does not appear in the PR

Signed-off-by: ossdev07 <ossdev@puresoftware.com>
@Carreau
Copy link
Member

@Carreau Carreau commented Jan 7, 2020

Oh, that's a lot of new entries in the test-matrix. Do you think they are all necessary ? It will likely quite increase the time to run all the tests. We also do not have compiled code; so is ti really worth it ; or should we maybe test only on things that would potentially break on CPython ie the -dev or 3.8 and nightly ?

@Carreau
Copy link
Member

@Carreau Carreau commented Jan 12, 2020

Merging for now; but if that make CI too slow; I might trim a few.

@Carreau Carreau merged commit 8f536d2 into ipython:master Jan 12, 2020
2 checks passed
@Carreau Carreau added this to the 7.12 milestone Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants