Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start multi-line __repr__s on their own line #12099

Merged
merged 4 commits into from
Jan 31, 2020
Merged

Start multi-line __repr__s on their own line #12099

merged 4 commits into from
Jan 31, 2020

Conversation

eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Jan 27, 2020 •
edited
Loading

Fixes gh-12098, by producing the output in the second code-block on that page:

In [115]: [Rectangle(3, 4), Rectangle(6, 2), 0, 1]
Out[115]:
[+---+
 |###|
 |###|
 +---+,
 +-+
 |#|
 |#|
 |#|
 |#|
 |#|
 +-+, 0, 1]

Related to gh-3851

@eric-wieser eric-wieser mentioned this pull request Jan 27, 2020
Open
@eric-wieser
Simplify and extend the test for multiline repr
16865e0 
`BreakingReprParent` is not really necessary here, testing using lists is easier to understand, and lets us test multiple lengths of list.
@eric-wieser
Try and use groups instead
5741513
Carreau
Carreau reviewed Jan 31, 2020
View reviewed changes
IPython/lib/pretty.py Outdated Show resolved Hide resolved
@Carreau Carreau merged commit d7cd43d into ipython:master Jan 31, 2020
@Carreau Carreau added this to the 7.12 milestone Jan 31, 2020
@Carreau
Copy link
Member

Carreau commented Jan 31, 2020

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carreau Carreau Carreau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.12
Development

Successfully merging this pull request may close these issues.

Pretty printing of lists of objects with multiline reprs is suboptimal
2 participants
@eric-wieser @Carreau