Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start multi-line __repr__s on their own line #12099

Merged
merged 4 commits into from Jan 31, 2020
Merged

Conversation

eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Jan 27, 2020

Fixes gh-12098, by producing the output in the second code-block on that page:

In [115]: [Rectangle(3, 4), Rectangle(6, 2), 0, 1]
Out[115]:
[+---+
 |###|
 |###|
 +---+,
 +-+
 |#|
 |#|
 |#|
 |#|
 |#|
 +-+, 0, 1]

Related to gh-3851

eric-wieser added 2 commits Jan 27, 2020
`BreakingReprParent` is not really necessary here, testing using lists is easier to understand, and lets us test multiple lengths of list.
IPython/lib/pretty.py Outdated Show resolved Hide resolved
@Carreau Carreau merged commit d7cd43d into ipython:master Jan 31, 2020
2 checks passed
@Carreau Carreau added this to the 7.12 milestone Jan 31, 2020
@Carreau
Copy link
Member

@Carreau Carreau commented Jan 31, 2020

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants