Remove py2 workarounds 1/2 #12110
Merged
Remove py2 workarounds 1/2 #12110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
reviewed
Feb 1, 2020
IPython/core/ultratb.py
Outdated
| generate_tokens = tokenize.generate_tokens | ||
| except AttributeError: # Python 3 | ||
| generate_tokens = tokenize.tokenize | ||
| generate_tokens = tokenize.tokenize |
There was a problem hiding this comment.
The comments appear to be wrong, generate_tokens = tokenize.generate_tokens work on Python 3; and this is likely the cause for the test failures.
It looks like the try/except comments were wrong and generate_tokens is available on Py3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking up #12092, per discussion.