Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop the last if path ends with slash #12122

Merged
merged 2 commits into from Feb 13, 2020
Merged

Pop the last if path ends with slash #12122

merged 2 commits into from Feb 13, 2020

Conversation

Inception95
Copy link
Contributor

@Inception95 Inception95 commented Feb 11, 2020

Hi, I made some changes on the _elide() function in ptutils.py and the test_elide() in test_interactiveshell.py:

  1. Pop the last empty string of the "file_parts" list if the input folder path ends with a slash.
  2. Add the test to this situation, but I am not sure it's ok to use os.sep?

#12105

@Inception95 Inception95 requested a review from Carreau Feb 12, 2020
@Carreau Carreau merged commit 201acc8 into ipython:master Feb 13, 2020
2 checks passed
@Carreau Carreau added this to the 7.13 milestone Feb 13, 2020
@Carreau
Copy link
Member

@Carreau Carreau commented Feb 13, 2020

@meeseeksdev backport to 7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants