Use default shortcuts with terminal debugger #12132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses `create_ipython_shortcuts` also for `TerminalPdb`, which then allows for using e.g. `F2` there also etc. `create_ipython_shortcuts` is used in `TerminalInteractiveShell.init_prompt_toolkit_cli` otherwise only, also passing them to `PromptSession` then only. Therefore this could be done there (in `PromptSession`) by default maybe even.
|
That looks reasonable ; thanks ! |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Feb 27, 2020
Carreau
added a commit
that referenced
this pull request
Feb 27, 2020
…132-on-7.x Backport PR #12132 on branch 7.x (Use default shortcuts with terminal debugger)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
create_ipython_shortcutsalso forTerminalPdb, which thenallows for using e.g.
F2there also etc.create_ipython_shortcutsis used inTerminalInteractiveShell.init_prompt_toolkit_cliotherwise only, alsopassing them to
PromptSessionthen only.Therefore this could be done there (in
PromptSession) by default maybeeven.