Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default shortcuts with terminal debugger #12132

Merged
merged 1 commit into from Feb 27, 2020

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 16, 2020

This uses create_ipython_shortcuts also for TerminalPdb, which then
allows for using e.g. F2 there also etc.

create_ipython_shortcuts is used in
TerminalInteractiveShell.init_prompt_toolkit_cli otherwise only, also
passing them to PromptSession then only.
Therefore this could be done there (in PromptSession) by default maybe
even.

This uses `create_ipython_shortcuts` also for `TerminalPdb`, which then
allows for using e.g. `F2` there also etc.

`create_ipython_shortcuts` is used in
`TerminalInteractiveShell.init_prompt_toolkit_cli` otherwise only, also
passing them to `PromptSession` then only.
Therefore this could be done there (in `PromptSession`) by default maybe
even.
@Carreau Carreau added this to the 8.0 milestone Feb 27, 2020
@Carreau Carreau removed this from the 8.0 milestone Feb 27, 2020
@Carreau Carreau added this to the 7.13 milestone Feb 27, 2020
@Carreau
Copy link
Member

@Carreau Carreau commented Feb 27, 2020

That looks reasonable ; thanks !

@Carreau Carreau merged commit 1b7ac22 into ipython:master Feb 27, 2020
2 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/ipython that referenced this issue Feb 27, 2020
Carreau added a commit that referenced this issue Feb 27, 2020
…132-on-7.x

Backport PR #12132 on branch 7.x (Use default shortcuts with terminal debugger)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants