Add option to change HTML attributes in display.Video #12212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanov
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
This looks great, @mancellin! I like how you've already added the new functionality to the examples AND spruced up the formatting of the doc string for the rendered API docs ! 🍰
|
Thanks ! That looks great, and thanks @ivanov for the first review. Merging, that should be out by end of month ! |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Apr 18, 2020
Carreau
added a commit
that referenced
this pull request
Apr 19, 2020
…212-on-7.x Backport PR #12212 on branch 7.x (Add option to change HTML attributes in display.Video)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to display video in a Jupyter notebook, and I would like to customize the behaviour of the video by changing some of the attributes of the HTML5 element (autoplay, loop, muted, ... see e.g. [1])
[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video
This PR allows this by adding an option to the Video constructor:
Another solution would have been to add boolean options for each properties
but that might be too cumbersome to maintain for such a specialized feature.