-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with the latest release of Sphinx #12235
Conversation
`l_` from sphinx.locale has been deprecated for a long time. `_` is the new name for the same function but it seems that the imports there are useless. sphinx-doc/sphinx@8d653a4
I am not sure but it seems that the CI problem isn't related to this change. Am I right? |
It seem to be due to the fact that Sphinx 3 now seem to treat duplicate items as error. |
Duplicate configtraits warnings are causing CI failures
I've pushed commit that should fix the CI build, woudl you mind having a look to make sure that make sens and I did not miss anything ? Thanks ! |
All the changes you have made seem reasonable to me and CI is happy now. It might be good to check that there is no reference to |
There is another MyKernel somewhere else, and sphinx was complaining about duplicates.
It's easy enough to revert commits, and ARM has been troublesome enough. Thanks, merging. |
@meeseeksdev backport to 7.x |
…235-on-7.x Backport PR #12235 on branch 7.x (Fix compatibility with the latest release of Sphinx)
l_
from sphinx.locale has been deprecated for a long time._
is the new name for the same function but it seems that theimports there are useless.
sphinx-doc/sphinx@8d653a4
Let's see what CI thinks about this change.