Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with the latest release of Sphinx #12235

Merged
merged 4 commits into from Apr 17, 2020

Conversation

frenzymadness
Copy link
Contributor

@frenzymadness frenzymadness commented Apr 14, 2020

l_ from sphinx.locale has been deprecated for a long time.
_ is the new name for the same function but it seems that the
imports there are useless.

sphinx-doc/sphinx@8d653a4

Let's see what CI thinks about this change.

`l_` from sphinx.locale has been deprecated for a long time.
`_` is the new name for the same function but it seems that the
imports there are useless.

sphinx-doc/sphinx@8d653a4
@frenzymadness
Copy link
Contributor Author

@frenzymadness frenzymadness commented Apr 14, 2020

I am not sure but it seems that the CI problem isn't related to this change. Am I right?

@Carreau
Copy link
Member

@Carreau Carreau commented Apr 15, 2020

I am not sure but it seems that the CI problem isn't related to this change. Am I right?

It seem to be due to the fact that Sphinx 3 now seem to treat duplicate items as error.
As we do autogenerate our API documentation, it sees duplicated between subclasses, and building the docs ends up being an error.

@Carreau
Copy link
Member

@Carreau Carreau commented Apr 15, 2020

I've pushed commit that should fix the CI build, woudl you mind having a look to make sure that make sens and I did not miss anything ?

Thanks !

@frenzymadness
Copy link
Contributor Author

@frenzymadness frenzymadness commented Apr 16, 2020

All the changes you have made seem reasonable to me and CI is happy now. It might be good to check that there is no reference to MyKernel left in the documentation. Also, it might make sense to comment out arm architecture from Travis config so it can be simply uncommented in the future.

@Carreau
Copy link
Member

@Carreau Carreau commented Apr 17, 2020

It might be good to check that there is no reference to MyKernel left in the documentation

There is another MyKernel somewhere else, and sphinx was complaining about duplicates.

Also, it might make sense to comment out arm architecture from Travis config so it can be simply uncommented in the future.

It's easy enough to revert commits, and ARM has been troublesome enough.

Thanks, merging.

@Carreau Carreau merged commit a5a8218 into ipython:master Apr 17, 2020
2 checks passed
@Carreau Carreau added this to the 7.14 milestone Apr 17, 2020
@Carreau
Copy link
Member

@Carreau Carreau commented Apr 17, 2020

@meeseeksdev backport to 7.x

meeseeksmachine pushed a commit to meeseeksmachine/ipython that referenced this issue Apr 17, 2020
Carreau added a commit that referenced this issue Apr 18, 2020
…235-on-7.x

Backport PR #12235 on branch 7.x (Fix compatibility with the latest release of Sphinx)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants