Exceptions raised when executing notebooks via the %run magic command

[palewire]

A first step toward fixing #12291. I only addressed the execution of ipynb files because I lacked the confidence to edit the complex shell operations below.

It's unclear to me if you would want the ultimate solution to be this narrowly tailored, or if you'd prefer other elements of this function to change behavior as well. If you let me know what you'd like, I can attempt to implement it.

I can verify that this modest patch did in fact work in my notebook testing.

[choldgraf]

This seems good to me! Do you think we could add a test to make sure that this will properly fail when run on a notebook w/ a %run that doesn't work? (though I am not super familiar with ipython's testing infra...maybe @MSeal has a better idea than I?)

[MSeal]

I think you need to change all the places with a return above the line you edited to instead raise the given exception (or create one). Otherwise typos or missing files will error silently and not raise as well.

[MSeal]

This seems good to me! Do you think we could add a test to make sure that this will properly fail when run on a notebook w/ a %run that doesn't work? (though I am not super familiar with ipython's testing infra...maybe @MSeal has a better idea than I?)

Doesn't have to be notebook specific. A test could be to call the run function with an execution target that will always fail and make sure it raises an exception. To be thorough, have a test for each failure path to ensure if raises an exception.

[palewire]

@MSeal I've added some additional exceptions. Is that what you were after?

[MSeal]

@palewire Yep. I think you missed one more:

ipython/IPython/core/magics/execution.py

Line 676 in 6bde670

return

[palewire]

Okay @MSeal, I've added that one yet too. Anything else I can do?

[MSeal]

Probably to make this mergable, we need some updated or new tests in https://github.com/ipython/ipython/blob/master/IPython/core/tests/test_run.py.

Thanks for contributing and getting this fixed btw :)

[MSeal]

@Carreau Can comment if there's anything else since he's the maintainer here

[palewire]

I've pushed a fresh commit with some unit tests. Take a look and let me know what else I can do.

[choldgraf]

Nice! It looks good to me!

[MSeal]

LGTM

[palewire]

Thanks, guys. @Carreau, let me know if there's anything else I can do.

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

$ git checkout 7.x
$ git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 c24e8af4bf631b51ddec077d13022aba00dcf30e

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #12301: Exceptions raised when executing notebooks via the %run magic command'

4. Push to a named branch :

git push YOURFORK 7.x:auto-backport-of-pr-12301-on-7.x

5. Create a PR against branch 7.x, I would have named this PR:

"Backport PR #12301 on branch 7.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

[Carreau]

Thanks, looks good, sorry this ended up hidden with all the open PRs.