Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable high DPI scaling in qt.py #12314

Merged
merged 1 commit into from May 18, 2020

Conversation

tlambert03
Copy link
Contributor

This enables automatic scaling for the qt5 GUI backend based on the monitor's pixel density.
I haven't yet been able to find a case (on mac/linux/windows) in which this didn't just "do the right thing" depending on pixel density ... but let me know if someone here has already considered and rejected this approach (couldn't find anything in the issues).

It is possible for the end-user to enable this themselves with the QT_ENABLE_HIGHDPI_SCALING environment variable, but if the user doesn't know to do that, any downstream Qt-based application that runs in the IPython event loop will not be able to correct scaling on a high DPI monitor, since it has to be set before creating the QApplication (we're running into this with napari)

Reference: https://doc.qt.io/qt-5/highdpi.html

@Carreau
Copy link
Member

Carreau commented May 16, 2020

Thanks!

@ccordoba12 will that affect you in Spyder, and are you ok with this ?

@Carreau Carreau added this to the 7.15 milestone May 18, 2020
@Carreau Carreau merged commit d9b3b6a into ipython:master May 18, 2020
2 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/ipython that referenced this pull request May 18, 2020
@tlambert03 tlambert03 deleted the enable-high-dpi branch May 18, 2020 23:12
@tlambert03
Copy link
Contributor Author

thanks!

@Carreau
Copy link
Member

Carreau commented May 19, 2020

That will be backported on 7.15 which should be released at end of month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants