Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto formatting to be called only once. #12336

Merged
merged 1 commit into from May 26, 2020

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented May 25, 2020

There seem to be a small race-condition when trying to reformat the text
twice in a short amount of time where some of the non-changed test
diapear. For example

async def b():pass

Lead to two reformatting where one does not see the async keyword
anymore., and would thus dedent the def by 1 space.

There seem to be a small race-condition when trying to reformat the text
twice in a short amount of time where some of the non-changed test
diapear. For example

    async def b():pass

Lead to two reformatting where one does not see the `async` keyword
anymore., and would thus dedent the def by 1 space.
@Carreau Carreau added this to the 7.15 milestone May 25, 2020
@Carreau Carreau merged commit 3546aed into ipython:master May 26, 2020
2 checks passed
@Carreau Carreau deleted the black_formatting branch May 26, 2020
meeseeksmachine pushed a commit to meeseeksmachine/ipython that referenced this issue May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant