use $SHELL in system_piped #12360
Merged
use $SHELL in system_piped #12360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we already use this in our call to subprocess.call in system_raw used in the terminal
this makes kernel behavior better match terminal IPython
For an example that used to be different:
!wc -l <(pwd)
with `SHELL=bash`
|
Bonus: this is my first PR to IPython in a very long time! |
|
Thanks ! And welcome back ! I miss you here ! |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Jun 2, 2020
Carreau
added a commit
that referenced
this pull request
Jun 2, 2020
…360-on-7.x Backport PR #12360 on branch 7.x (use $SHELL in system_piped)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we already use this in our call to subprocess.call in system_raw used in the terminal.
This makes kernel behavior (system_piped) better match terminal IPython (system_raw) on posix systems.
For an example that used to be different:
with
SHELL=bashreported on discourse: https://discourse.jupyter.org/t/ipython-process-subsitution-and/4645