Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use $SHELL in system_piped #12360

Merged
merged 1 commit into from Jun 2, 2020
Merged

use $SHELL in system_piped #12360

merged 1 commit into from Jun 2, 2020

Conversation

minrk
Copy link
Member

@minrk minrk commented Jun 2, 2020

we already use this in our call to subprocess.call in system_raw used in the terminal.

This makes kernel behavior (system_piped) better match terminal IPython (system_raw) on posix systems.

For an example that used to be different:

!wc -l <(pwd)

with SHELL=bash

reported on discourse: https://discourse.jupyter.org/t/ipython-process-subsitution-and/4645

we already use this in our call to subprocess.call in system_raw used in the terminal

this makes kernel behavior better match terminal IPython

For an example that used to be different:

    !wc -l <(pwd)

with `SHELL=bash`
@minrk
Copy link
Member Author

minrk commented Jun 2, 2020

Bonus: this is my first PR to IPython in a very long time!

@Carreau Carreau added this to the 7.16 milestone Jun 2, 2020
@Carreau Carreau merged commit 9da0974 into ipython:master Jun 2, 2020
2 checks passed
@Carreau
Copy link
Member

Carreau commented Jun 2, 2020

Thanks ! And welcome back ! I miss you here !

meeseeksmachine pushed a commit to meeseeksmachine/ipython that referenced this issue Jun 2, 2020
Carreau added a commit that referenced this issue Jun 2, 2020
…360-on-7.x

Backport PR #12360 on branch 7.x (use $SHELL in system_piped)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants