Allow passing extra options to TerminalPdb.pt_init #12407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, subclasses of TerminalPdb (like in https://github.com/kmaork/madbg/blob/master/madbg/debugger.py#L55) will have to duplicate the entire pt_init method in order to add additional arguments for the prompt session (which accepts about 40 of them). An example would be a subclass that wants to write the prompts to a different output stream than the default. After this change it would just have to override the call to pt_init with `pt_init(dict(input=input, output=output))`
|
Sweet ! Nice project ! I've marked that at 8.0, but it can easily be backported to 7.x later on if you wish. |
|
Thank you!! How should I go about backporting it? |
Once you're happy with your project, just ask and depending on how far I an in the 8.0 release I can cherry-pick the commit on 7.x, I do a 7.x release every last friday of the month. |
|
Awesome, thanks! |
|
Hi @Carreau ! I'm pretty happy with my project, so a backport would be awesome :) |
|
@meeseeksdev backport to 7.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Jul 6, 2020
Carreau
added a commit
that referenced
this pull request
Jul 6, 2020
…407-on-7.x Backport PR #12407 on branch 7.x (Allow passing extra options to TerminalPdb.pt_init)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, subclasses of
TerminalPdb(like in https://github.com/kmaork/madbg/blob/master/madbg/debugger.py#L55) will have to duplicate the entirept_initmethod in order to add additional arguments for the prompt session (which accepts about 40 of them).An example for the need to pass arguments to the prompt session would be a subclass that wants to write the prompts to a different output stream than the default. After this change it would just have to override the call to
pt_initwithpt_init(dict(input=input, output=output))