Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Move extraction of local scope to a method #12437

Merged
merged 1 commit into from Jul 14, 2020

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Jul 13, 2020

When calling ipython magic from pdb, the locals need to be set from the pdb locals, which is different from the frame locals. Moving this call to a method enables a subclass to change the behaviour of get_local_scope to make this possible. This would enable using %timeit while debugging in Spyder for example.

When calling ipython magic from pdb, the locals need to be set from the pdb locals, which is different from the frame locals. Moving this call to a method enables a subclass to change the behaviour of `get_local_scope` to make this possible. This would enable using `%timeit` while debugging in Spyder for example
@Carreau Carreau added this to the 7.17 milestone Jul 14, 2020
@Carreau Carreau merged commit 0dc2173 into ipython:master Jul 14, 2020
2 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/ipython that referenced this pull request Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants