allow specifying multiple extensions on the command-line with traitlets 5 #12543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
reviewed
Sep 4, 2020
for backward-compatibility, add new `extra_extensions` list Use new list only with traitlets 5, keep old singleton behavior with traitlets 4
minrk
force-pushed
the
multiple-extensions
branch
from
3c96146
to
a346353
Compare
Carreau
reviewed
Sep 7, 2020
| ).tag(config=True) | ||
|
|
||
| extra_extensions = List( | ||
| DottedObjectName(), |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Sep 7, 2020
…e command-line with traitlets 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In traitlets 4, only one extension could be loaded with
--ext, so:would only actually load
autoreload, the last occurrence, silently ignoring Cython. With traitlets 5, this silent failure to activate two extensions has turned into an error (see ipython/traitlets#614).But this syntax Just Works™ for List traits with traitlets 5, so this PR adds a new
extra_extensionsplural trait that behaves the same as the existing one, while adding support for specifying multiple extensions if the alias is given multiple times.For backwards-compatibility, instead of updating in-place, add a new
extra_extensionslist and point the--extalias to the new list on traitlets 5 and leave it on the existingextra_extensionon traitlets 4.closes #12541
closes ipython/traitlets#614