Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

use self.kernel_manager_class in qtconsoleapp #1257

Merged
merged 1 commit into from

2 participants

Min RK Brian E. Granger
Min RK
Owner

ShellApp derivatives have a kernel_manager_class, so that it's easier to change what should be used in subclasses. The QtConsole was not updated to use this for tabs other than the first. This small PR makes that change.

Brian E. Granger
Owner

This looks great, merge whenever you want.

Min RK minrk merged commit 5d833ca into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 12, 2012
  1. Min RK
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 IPython/frontend/qt/console/qtconsoleapp.py
4 IPython/frontend/qt/console/qtconsoleapp.py
View
@@ -178,7 +178,7 @@ def new_frontend_master(self):
""" Create and return new frontend attached to new kernel, launched on localhost.
"""
ip = self.ip if self.ip in LOCAL_IPS else LOCALHOST
- kernel_manager = QtKernelManager(
+ kernel_manager = self.kernel_manager_class(
ip=ip,
connection_file=self._new_connection_file(),
config=self.config,
@@ -204,7 +204,7 @@ def new_frontend_slave(self, current_widget):
current_widget : IPythonWidget
The IPythonWidget whose kernel this frontend is to share
"""
- kernel_manager = QtKernelManager(
+ kernel_manager = self.kernel_manager_class(
connection_file=current_widget.kernel_manager.connection_file,
config = self.config,
)
Something went wrong with that request. Please try again.