use self.kernel_manager_class in qtconsoleapp #1257

Merged
merged 1 commit into from Jan 16, 2012

Conversation

Projects
None yet
2 participants
Owner

minrk commented Jan 12, 2012

ShellApp derivatives have a kernel_manager_class, so that it's easier to change what should be used in subclasses. The QtConsole was not updated to use this for tabs other than the first. This small PR makes that change.

Owner

ellisonbg commented Jan 15, 2012

This looks great, merge whenever you want.

minrk added a commit that referenced this pull request Jan 16, 2012

Merge pull request #1257 from minrk/kmclass
use self.kernel_manager_class in qtconsoleapp

Subclasses of QtConsoleApp can now override kernel_manager_class with their own version.

@minrk minrk merged commit 5d833ca into ipython:master Jan 16, 2012

minrk added a commit that referenced this pull request Jan 18, 2012

Merge pull request #1257 from minrk/kmclass
use self.kernel_manager_class in qtconsoleapp

Subclasses of QtConsoleApp can now override kernel_manager_class with their own version.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #1257 from minrk/kmclass
use self.kernel_manager_class in qtconsoleapp

Subclasses of QtConsoleApp can now override kernel_manager_class with their own version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment