Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Improve installing docs if on zsh #12587

Merged
merged 1 commit into from Oct 6, 2020
Merged

Conversation

hongshaoyang
Copy link
Contributor

  • zsh uses square brackets for globbing (see https://stackoverflow.com/a/30539963).
  • installation would be confusing for zsh users who will get a 'no matches found' error when running pip install .[test]

- zsh uses square brackets for globbing (see https://stackoverflow.com/a/30539963).
- installation would be confusing for zsh users who will get a 'no matches found' error without the quotes
@Carreau Carreau modified the milestones: 7.18, 7.19 Oct 6, 2020
@Carreau Carreau merged commit 7bea916 into ipython:master Oct 6, 2020
2 checks passed
@Carreau
Copy link
Member

Carreau commented Oct 6, 2020

Thanks.

meeseeksmachine pushed a commit to meeseeksmachine/ipython that referenced this pull request Oct 6, 2020
Carreau added a commit that referenced this pull request Oct 12, 2020
…587-on-7.x

Backport PR #12587 on branch 7.x ([Docs] Improve installing docs if on zsh)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants