HeartMonitor.period should be an Integer #1283

Merged
merged 1 commit into from Jan 18, 2012

Conversation

Projects
None yet
2 participants
Owner

minrk commented Jan 17, 2012

millisecond times should generally be integers, because any time they are specified with fractional precision it is probable that the user believes the units are seconds, and an error should be raised.

closes #1281

HeartMonitor.period should be an Integer
millisecond times should generally be integers, because any time they
are specified with fractional precision it is probable that the user
believes the units are seconds, and an error should be raised.
Owner

ellisonbg commented Jan 18, 2012

This looks ready to merge.

minrk added a commit that referenced this pull request Jan 18, 2012

Merge pull request #1283 from minrk/i1281
HeartMonitor.period is now an Integer

millisecond times should generally be integers, because any time they are specified with fractional precision it is probable that the user believes the units are seconds, and an error should be raised.

closes #1281

@minrk minrk merged commit 8e9cbc1 into ipython:master Jan 18, 2012

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #1283 from minrk/i1281
HeartMonitor.period is now an Integer

millisecond times should generally be integers, because any time they are specified with fractional precision it is probable that the user believes the units are seconds, and an error should be raised.

closes #1281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment