Skip to content

a fix for GH 1269 #1284

Merged
merged 3 commits into from Jan 18, 2012

2 participants

@ivanov
IPython member
ivanov commented Jan 18, 2012

Here's a test and fix for #1269. I originally thought the fix was going to be in magic.py, and went ahead and fixed the typos in that file, but it turned out that the fix ended up going into _process_common.py - hope that's ok.

@minrk
IPython member
minrk commented Jan 18, 2012

Nice! Looks sensible to me. I imagine we are likely to run into this sort of thing a few more times before we rewrite the magic arg-splitting in a cleaner way.

The process_common thing is a bit funky - we really should not be using the same code to split magic arguments and split strings into a Popen command-list, but we do, so your fix is probably in the right place. That's more for the major reorganization of magics that @fperez has in mind.

@minrk
IPython member
minrk commented Jan 18, 2012

needs a quick rebase, due to some unfortunate cleanup that had to be done in master.

@ivanov ivanov merged commit dc5f6f6 into ipython:master Jan 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.