Skip to content

Fixing CM related indentation problems. #1311

Closed
wants to merge 14 commits into from

2 participants

@ellisonbg
IPython member
  • Block indent/dedent now works.
  • Tab works in docstrings.
ellisonbg added some commits Jan 17, 2012
@ellisonbg ellisonbg Updating to CodeMirror 2.2, latest stable release. 7d2dff1
@ellisonbg ellisonbg Fixing bugs that have shown up since updating CM to 2.2. 911dba0
@ellisonbg ellisonbg Work on the base Cell API.
* Added set_text/get_text in favor of get_code/set_code and
  get_source/set_source.
* Added methods to the base class (get_text, set_text, refresh,
  edit, render, toJSON, fromJSON).
f790de5
@ellisonbg ellisonbg Updating cell logic.
* Added placeholder to the base Cell class.
* Removed the \u0000 char at the beginning of the TextCell
  placeholder that was there for a CodeMirror bug workaround.
* Other refactoring of Cell related Notebook methods.
5281dc6
@ellisonbg ellisonbg Refactoring of the notebooks cell management.
* Cell insertion code completely rewritten. We now have two methods
  rather than 9: insert_cell_above, insert_cell_below.
* Renaming methods to be more consistent.
* Creating new methods to provide a uniform API.
* Minor bug fixes.
fd82b35
@ellisonbg ellisonbg Lots of small notebook improvements.
* Merge/split works for all cell types.
* Notebook.select won't select an already selected cell.
* Bugs in markdown cell editing fixed.
* border-box-sizing used for Markdown cells to get correct css boxes.
* Shading/border added to Markdown cell editor.
357e3e6
@ellisonbg ellisonbg Ace editor now works with Markdown and HTML cells with proper modes. cbd3102
@ellisonbg ellisonbg Start the pager out collapsed. 9ad2978
@ellisonbg ellisonbg Optimizing notebook loading. 197288e
@ellisonbg ellisonbg Fixing bugs in CodeMirror refreshing. 5caff73
@ellisonbg ellisonbg Adding refresh/focus/refresh back to edit to fix bug in FF. 9617295
@fawce
fawce commented Jan 23, 2012

chrome on mac osx 10.6:

  • block indent/dedent works, but it did before too.
  • tab in docstrings now works, where it didn't before. just to be clear, docstrings are not auto-indenting when i hit enter on a docstring line, but I don't think this fix was trying to handle that.
@ellisonbg
IPython member

I am going to close this as this work will be merged in a different branch.

@ellisonbg ellisonbg closed this Jan 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.