New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor heartbeat tweaks #1312

Merged
merged 2 commits into from Jan 23, 2012

Conversation

Projects
None yet
2 participants
@minrk
Member

minrk commented Jan 23, 2012

two small changes:

  • flush outgoing heartbeats:
    • Prevents mismatch between heartbeat timer and actual heartbeat send/recv events.
    • Applied in notebook and parallel.
  • relax default heartbeat period in IPython.parallel to 3s from 1s
    • Matches heartbeats elsewhere. 3s should be extremely conservative, as most heartbeat responses are O(1ms) unless there's a bug in our code (like the above flush and previously-discovered GIL issues).

closes #1304

minrk added some commits Jan 23, 2012

flush outgoing heartbeats
Prevents mismatch between heartbeat timer and actual heartbeat send/recv events.

Applied in notebook and parallel.
relax default heartbeat period in IPython.parallel to 3s (from 1s)
Matches heartbeats elsewhere.  3s should be extremely conservative,
as most heartbeat responses are O(1ms).
@ellisonbg

This comment has been minimized.

Show comment
Hide comment
@ellisonbg

ellisonbg Jan 23, 2012

Member

This looks good - I think it can be merged.

Member

ellisonbg commented Jan 23, 2012

This looks good - I think it can be merged.

minrk added a commit that referenced this pull request Jan 23, 2012

Merge pull request #1312 from minrk/hb
two small heartbeat changes:

* flush outgoing heartbeats (notebook and parallel):
  - Prevents mismatch between heartbeat timer and actual heartbeat send/recv events.

* relax default heartbeat period in IPython.parallel to 3s from 1s
  - Matches heartbeats elsewhere.  3s should be extremely conservative, as most heartbeat responses are O(1ms) unless there's a bug in our code (like the above flush and previously-discovered GIL issues).

closes #1304

@minrk minrk merged commit 1487f2f into ipython:master Jan 23, 2012

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request ipython#1312 from minrk/hb
two small heartbeat changes:

* flush outgoing heartbeats (notebook and parallel):
  - Prevents mismatch between heartbeat timer and actual heartbeat send/recv events.

* relax default heartbeat period in IPython.parallel to 3s from 1s
  - Matches heartbeats elsewhere.  3s should be extremely conservative, as most heartbeat responses are O(1ms) unless there's a bug in our code (like the above flush and previously-discovered GIL issues).

closes ipython#1304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment