minor heartbeat tweaks #1312

Merged
merged 2 commits into from Jan 23, 2012

Projects

None yet

2 participants

@minrk
Member
minrk commented Jan 23, 2012

two small changes:

  • flush outgoing heartbeats:
    • Prevents mismatch between heartbeat timer and actual heartbeat send/recv events.
    • Applied in notebook and parallel.
  • relax default heartbeat period in IPython.parallel to 3s from 1s
    • Matches heartbeats elsewhere. 3s should be extremely conservative, as most heartbeat responses are O(1ms) unless there's a bug in our code (like the above flush and previously-discovered GIL issues).

closes #1304

minrk added some commits Jan 23, 2012
@minrk minrk flush outgoing heartbeats
Prevents mismatch between heartbeat timer and actual heartbeat send/recv events.

Applied in notebook and parallel.
d545c3b
@minrk minrk relax default heartbeat period in IPython.parallel to 3s (from 1s)
Matches heartbeats elsewhere.  3s should be extremely conservative,
as most heartbeat responses are O(1ms).
a4d4ccc
@ellisonbg
Member

This looks good - I think it can be merged.

@minrk minrk merged commit 1487f2f into ipython:master Jan 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment