Skip to content

Saving non-ascii history #1377

Merged
merged 3 commits into from Feb 18, 2012

3 participants

@takluyver
IPython member

Non ascii history caused problems for the %hist command with the -f option to save to file (#1375). This adds a test and fixes it.

@c000de
c000de commented on a66f7c9 Feb 6, 2012

So io.open has an encoding parameter, learned a new thing today :) Nice fix! Better/neater than the solution I had in mind too.

IPython member

Yep, I discovered io.open recently - it's essentially the open() function from Python 3, available in Python 2.6 and above.

@minrk
IPython member
minrk commented Feb 11, 2012

Seems like we want to be using io.open everywhere, is this true? Can you perhaps write up a simple policy note on that, either in dev docs, or your py3/unicode wiki page?

@takluyver
IPython member

Yes, I expect it will be useful. I'll put it on the wiki page.

@minrk minrk merged commit fd42bee into ipython:master Feb 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.