Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for %tb magic. #1396

Merged
merged 1 commit into from Feb 11, 2012

Conversation

Projects
None yet
2 participants
Owner

takluyver commented Feb 9, 2012

In order for the %tb magic to work as expected, no other error can be raised by invoking it. Even if an error is caught immediately, it affects the 'last error' values in sys.

This cuts a try/except block out of ip.magic(). Happily, in this case there was a simpler way to do the same thing.

@minrk minrk added a commit that referenced this pull request Feb 11, 2012

@minrk minrk Merge pull request #1396 from takluyver/magic_tb_fix
In order for the %tb magic to work as expected, no other error can be raised by invoking it. Even if an error is caught immediately, it affects the 'last error' values in sys.

This cuts a try/except block out of ip.magic(). Happily, in this case there was a simpler way to do the same thing using `str.partition`
920beab

@minrk minrk merged commit 920beab into ipython:master Feb 11, 2012

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

@minrk minrk Merge pull request #1396 from takluyver/magic_tb_fix
In order for the %tb magic to work as expected, no other error can be raised by invoking it. Even if an error is caught immediately, it affects the 'last error' values in sys.

This cuts a try/except block out of ip.magic(). Happily, in this case there was a simpler way to do the same thing using `str.partition`
54595af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment