Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Ipy3 preparation #159
This is my Python 2 branch to tidy up code for simpler automatic conversion to Python 3. It passes the test suite on my machine, although of course you may want to test it further.
Most of the changes shouldn't affect how the code works. They consist largely of dropping compatibility with older versions of Python. Fernando indicated that we can target Python 2.6 for IPython 0.11. The exception is the import_item function, which I rewrote using import. I don't know if there's a case in which that wouldn't work.
Very minor note:
Otherwise the changes look perfect. Let me know what you want to do with that one, and I'll go ahead and merge.
Great work, thanks!
Got it, thanks. In that case, I'm actually going to merge it with a note that this was old code which can be removed once we're 100% sure nothing got screwed up. It may save time if there's a problem, to someone looking for a fix, to have the old one right there instead of just in git's history.
Note (I'll send an email to the list about this): in general please don't merge from trunk into feature branches, to avoid criss-cross merges. Keep feature branches fast-forwarding as they evolve, or even rebase them if truly necessary. It makes the merge history much cleaner, and it's not an issue of pickiness, but of being able to more easily analyze in isolation what the branch does compared to the trunk (which a merge makes difficult).
I'll make the merge with your state pior to 753f7eb, and will add the builtins fix as well as a comment on the code from 7dfe077.
Thanks for the great work, this should be merged and closed in a minute.