Fix del method exit test #172

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
1 participant
Owner

takluyver commented Oct 16, 2010

This fixes a recent test that del methods, called on exit, are able to access built-in functions such as str(), so that the test will fail if that code is broken. It then reapplies Fernando's fix for the bug, which was removed by another commit in the meantime.

Owner

takluyver commented Oct 22, 2010

Merge branch 'fix-del-method-exit-test' of http://github.com/takowl/ipython into takowl-fix-del-method-exit-test

Fix errors with del methods being called on exit.

This branch reintroduces a recent fix that got accidentally
overwritten, as well as adding a more stringent form of the test so
that we don't miss it again in the future (the old test only printed a
message but didn't fail, so it was easy to miss).

Closed by 5c6a347 (pull request).

@markvoorhies markvoorhies pushed a commit to markvoorhies/ipython that referenced this pull request Apr 21, 2011

@takluyver @fperez takluyver + fperez Merge branch 'fix-del-method-exit-test' of http://github.com/takowl/i…
…python into takowl-fix-del-method-exit-test

Fix errors with __del__ methods being called on exit.

This branch reintroduces a recent fix that got accidentally
overwritten, as well as adding a more stringent form of the test so
that we don't miss it again in the future (the old test only printed a
message but didn't fail, so it was easy to miss).

Closes gh-172 (pull request).
5c6a347

@minrk minrk pushed a commit to minrk/ipython that referenced this pull request Jul 1, 2013

@Carreau Carreau Merge pull request #172 from Carreau/deepcopy
Deepcopy

rework of config system to fix non-configurability bugs.
15ccfd1

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

@takluyver @fperez takluyver + fperez Merge branch 'fix-del-method-exit-test' of http://github.com/takowl/i…
…python into takowl-fix-del-method-exit-test

Fix errors with __del__ methods being called on exit.

This branch reintroduces a recent fix that got accidentally
overwritten, as well as adding a more stringent form of the test so
that we don't miss it again in the future (the old test only printed a
message but didn't fail, so it was easy to miss).

Closes gh-172 (pull request).
2636437

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment